feat: HTTP Bearer Authorization for simple use cases#193
Open
robbat2 wants to merge 1 commit intoprometheus:masterfrom
Open
feat: HTTP Bearer Authorization for simple use cases#193robbat2 wants to merge 1 commit intoprometheus:masterfrom
robbat2 wants to merge 1 commit intoprometheus:masterfrom
Conversation
Member
|
I wonder if we should support arbitrary headers, rather than specifically one kind of bearer token. The reason we have the basic auth here is because there's some standard encoding involved. |
Author
|
I actually started considering other auth to add, including HTTP Digest (which also needs special handling like Basic) For your proposal, it would be match header to accept: |
Member
|
Some work on Digest auth was being done over in the common package. |
Add support for HTTP Bearer Authorization for simple use cases, where HTTP Basic might not fit workflows. Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
Author
|
@SuperQ hmm, reading that, I realize there is more auth support in common already that not being exposed in toolkit; should I include that in this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for HTTP Bearer Authorization for simple use cases, where HTTP Basic might not fit workflows.
Signed-off-by: Robin H. Johnson robbat2@gentoo.org